Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1649)

Issue 282173004: test.dart: Handle checkout paths containing spaces. (Closed)

Created:
6 years, 7 months ago by Bill Hesse
Modified:
6 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

test.dart: Handle checkout paths containing spaces. Change TestUtils to correctly convert from a URI to a file path, and simplify the setting of the path to the Dart checkout. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=36299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -26 lines) Patch
M tools/status_clean.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/testing/dart/http_server.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
6 years, 7 months ago (2014-05-19 13:09:37 UTC) #1
kustermann
LGTM
6 years, 7 months ago (2014-05-19 13:13:41 UTC) #2
Bill Hesse
6 years, 7 months ago (2014-05-19 14:30:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698