Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/testing/dart/drt_updater.dart

Issue 282173004: test.dart: Handle checkout paths containing spaces. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/co19_test.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/drt_updater.dart
===================================================================
--- tools/testing/dart/drt_updater.dart (revision 36288)
+++ tools/testing/dart/drt_updater.dart (working copy)
@@ -10,7 +10,6 @@
import "dart:io";
import "test_suite.dart";
-import "utils.dart" show Path;
class _DartiumUpdater {
String name;
@@ -40,9 +39,8 @@
}
List<String> get _getUpdateCommand {
- Path testScriptPath = new Path(TestUtils.testScriptPath);
- Path updateScriptPath = testScriptPath.directoryPath.append(script);
- List<String> command = [updateScriptPath.toNativePath()];
+ Uri updateScript = TestUtils.dartDirUri.resolve(script);
+ List<String> command = [updateScriptPath.toFilePath()];
if (null != option) {
command.add(option);
}
@@ -72,13 +70,15 @@
// Download the default content shell from Google Storage.
if (_contentShellUpdater == null) {
_contentShellUpdater = new _DartiumUpdater('Content Shell',
- 'get_archive.py', 'drt');
+ 'tools/get_archive.py',
+ 'drt');
}
return _contentShellUpdater;
} else if (runtime == 'dartium' && configuration['dartium'] == '') {
// Download the default Dartium from Google Storage.
if (_dartiumUpdater == null) {
- _dartiumUpdater = new _DartiumUpdater('Dartium Chrome', 'get_archive.py',
+ _dartiumUpdater = new _DartiumUpdater('Dartium Chrome',
+ 'tools/get_archive.py',
'dartium');
}
return _dartiumUpdater;
« no previous file with comments | « tools/testing/dart/co19_test.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698