Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 281383002: Reapply "Fix analyzer errors in html Dartium." (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Reapply "Fix analyzer errors in html Dartium." BUG= R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=36195

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -292 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +89 lines, -89 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +87 lines, -90 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 1 chunk +11 lines, -17 lines 0 comments Download
D tools/dom/src/WrappedEvent.dart View 1 chunk +0 lines, -90 lines 0 comments Download
A + tools/dom/src/dart2js_WrappedEvent.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + tools/dom/src/dartium_WrappedEvent.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Patch set 1 is identical to https://codereview.chromium.org//285123002, and Patch Set 2 is what I changed ...
6 years, 7 months ago (2014-05-14 23:01:33 UTC) #1
Leaf
lgtm
6 years, 7 months ago (2014-05-14 23:07:54 UTC) #2
Emily Fortuna
6 years, 7 months ago (2014-05-14 23:09:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r36195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698