Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 27903006: Improves how to initialize polymer apps and fixes polymer build and linter to (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Improves how to initialize polymer apps and fixes polymer build and linter to match Dartium semantics (Issue 14238). In particular: - only one script tag is allowed per document - initPolymer can be call from init.dart or the users main method, the build process knows how to call the user's main given the new Dartium semantics. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=28971

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -242 lines) Patch
M pkg/polymer/example/component/news/test/news_index_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/example/component/news/test/news_index_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/lib/builder.dart View 1 2 3 4 1 chunk +17 lines, -5 lines 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 1 2 3 4 chunks +55 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 7 chunks +19 lines, -19 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 1 2 3 4 chunks +58 lines, -69 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 2 3 3 chunks +37 lines, -11 lines 0 comments Download
M pkg/polymer/test/attr_deserialize_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/attr_deserialize_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/attr_mustache_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/attr_mustache_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/all_phases_test.dart View 1 2 3 6 chunks +22 lines, -24 lines 0 comments Download
M pkg/polymer/test/build/common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer/test/build/import_inliner_test.dart View 7 chunks +56 lines, -0 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 4 chunks +45 lines, -5 lines 0 comments Download
M pkg/polymer/test/build/polyfill_injector_test.dart View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M pkg/polymer/test/build/script_compactor_test.dart View 1 2 3 4 chunks +16 lines, -14 lines 0 comments Download
M pkg/polymer/test/event_path_test.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/polymer/test/event_path_test.html View 5 chunks +1 line, -29 lines 0 comments Download
M pkg/polymer/test/events_test.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/polymer/test/events_test.html View 3 chunks +1 line, -27 lines 0 comments Download
M pkg/polymer/test/instance_attrs_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/instance_attrs_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_bind_reflection_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_bind_reflection_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/publish_attributes_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/publish_attributes_test.html View 2 chunks +1 line, -1 line 0 comments Download
M pkg/polymer/test/take_attributes_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/test/take_attributes_test.html View 2 chunks +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/listorder_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M samples/third_party/todomvc/test/listorder_test.html View 2 chunks +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.html View 2 chunks +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/markdone_shadow_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_shadow_test.html View 2 chunks +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/markdone_test.dart View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M samples/third_party/todomvc/test/markdone_test.html View 2 chunks +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-18 23:43:09 UTC) #1
Siggi Cherem (dart-lang)
FYI - I just did one more upload, the only change is in pkg.status - ...
7 years, 2 months ago (2013-10-19 00:01:14 UTC) #2
Jennifer Messerly
the transformer changes are fine... but I'm worried about the test changes. The single-script-tag-per-document messes ...
7 years, 2 months ago (2013-10-19 00:15:47 UTC) #3
Jennifer Messerly
fwiw, code changes lgtm. Up to you if you think this is an improvement or ...
7 years, 2 months ago (2013-10-19 00:28:51 UTC) #4
Siggi Cherem (dart-lang)
+vsm totally fair. I have similar concerns. Vijay - I think we are going to ...
7 years, 2 months ago (2013-10-19 00:33:14 UTC) #5
Siggi Cherem (dart-lang)
just to write here what our conclusion was: we decided to go ahead with this ...
7 years, 2 months ago (2013-10-21 20:43:14 UTC) #6
Siggi Cherem (dart-lang)
John - I just merged your latest changes and will be submitting shortly. The only ...
7 years, 2 months ago (2013-10-21 23:29:39 UTC) #7
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-21 23:31:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r28971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698