Improves how to initialize polymer apps and fixes polymer build and linter to

pkg/polymer/lib/src/loader.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /** Annotation used to automatically register polymer elements. */
 class CustomTag {
   final String tagName;
   const CustomTag(this.tagName);
@@ skipping 14 matching lines @@
  *      [CustomTag] and invoke the initialization method on it. If [libraries]
  *      is null, first find all libraries that need to be loaded by scanning for
  *      HTML imports in the main document.
  *
  * The initialization on each library is a top-level function and annotated with
  * [initMethod].
  *
  * The urls in [libraries] can be absolute or relative to
  * `currentMirrorSystem().isolate.rootLibrary.uri`.
  */
-void initPolymer([List<String> libraries]) {
-  // Note: we synchronously load all libraries because the script invoking
-  // this is run after all HTML imports are resolved.
-  if (libraries == null) {
-    libraries = _discoverScripts(document, window.location.href);
+void initPolymer() {
+  if (_useDirtyChecking) {
+    dirtyCheckZone().run(_initPolymerOptimized);
+  } else {
+    _initPolymerOptimized();
   }
-  dirtyCheckZone().run(() => initPolymerOptimized(libraries));
 }
 
 /**
  * Same as [initPolymer], but runs the version that is optimized for deployment
  * to the internet. The biggest difference is it omits the [Zone] that
  * automatically invokes [Observable.dirtyCheck], and the list of libraries must
  * be supplied instead of being dynamically searched for at runtime.
  */
 // TODO(jmesserly): change the Polymer build step to call this directly.
-void initPolymerOptimized(List<String> libraries) {
+void _initPolymerOptimized() {
   preventFlashOfUnstyledContent();
 
   // TODO(jmesserly): mdv should use initMdv instead of mdv.initialize.
   mdv.initialize();
   document.register(PolymerDeclaration._TAG, PolymerDeclaration);
 
-  _loadLibraries(libraries);
+  _loadLibraries();
 }
 
-void _loadLibraries(libraries) {
-  for (var lib in libraries) {
+/**
+ * Configures [initPolymer] making it optimized for deployment to the internet.
+ * With this setup the list of libraries to initialize is supplied instead of
+ * being dynamically searched for at runtime. Additionally, after this method is
+ * called, [initPolymer] omits the [Zone] that automatically invokes
+ * [Observable.dirtyCheck].
+ */
+void configureForDeployment(List<String> libraries) {
+  _librariesToLoad = libraries;
+  _useDirtyChecking = false;
+}
+
+/**
+ * Libraries that will be initialized. For each library, the intialization
+ * registers any type tagged with a [CustomTag] annotation and calls any
+ * top-level method annotated with [initMethod]. The value of this field is
+ * assigned programatically by the code generated from the polymer deploy
+ * scripts. During development, the libraries are inferred by crawling HTML
+ * imports and searching for script tags.
+ */
+List<String> _librariesToLoad =
+    _discoverScripts(document, window.location.href);
+bool _useDirtyChecking = true;
+
+void _loadLibraries() {
+  for (var lib in _librariesToLoad) {
     try {
       _loadLibrary(lib);
     } catch (e, s) {
       // Deliver errors async, so if a single library fails it doesn't prevent
       // other things from loading.
       new Completer().completeError(e, s);
     }
   }
 
   customElementsReady.then((_) => Polymer._ready.complete());
 }
 
 /**
  * Walks the HTML import structure to discover all script tags that are
- * implicitly loaded.
+ * implicitly loaded. This code is only used in Dartium and should only be
+ * called after all HTML imports are resolved. Polymer ensures this by asking
+ * users to put their Dart script tags after all HTML imports (this is checked
+ * by the linter, and Dartium will otherwise show an error message).
  */
 List<String> _discoverScripts(Document doc, String baseUri,
     [Set<Document> seen, List<String> scripts]) {
   if (seen == null) seen = new Set<Document>();
   if (scripts == null) scripts = <String>[];
   if (seen.contains(doc)) return scripts;
   seen.add(doc);
 
   var inlinedScriptCount = 0;
   for (var node in doc.queryAll('script,link[rel="import"]')) {
@@ skipping 129 matching lines @@
     print("warning: methods marked with @initMethod should take no "
         "arguments, ${method.simpleName} expects some.");
     return;
   }
   obj.invoke(method.simpleName, const []);
 }
 
 class _InitMethodAnnotation {
   const _InitMethodAnnotation();
 }