Issue 27581002: Temporary disable string-interpolation constant folding until failures witj --optimization-counter-…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27581002: Temporary disable string-interpolation constant folding until failures witj --optimization-counter-… (Closed)

Created:
7 years, 2 months ago by srdjan

Modified:
7 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Temporary disable string-interpolation constant folding until failures witj --optimization-counter-threshold=5 are resolved. Committed: https://code.google.com/p/dart/source/detail?r=28749

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

TBR. fix for: stderr: runtime/vm/flow_graph_allocator.cc:312: error: expected: rep != kNoRepresentation Command[vm]: out/DebugIA32/dart --optimization-counter-threshold=5 --ignore-unrecognized-flags --package-root=out/DebugIA32/packages/ ...

7 years, 2 months ago (2013-10-16 20:51:38 UTC) #1

srdjan

Committed patchset #1 manually as r28749 (presubmit successful).

7 years, 2 months ago (2013-10-16 20:53:07 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages