Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 27581002: Temporary disable string-interpolation constant folding until failures witj --optimization-counter-… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 28746)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -6217,6 +6217,11 @@
void ConstantPropagator::VisitStringInterpolate(StringInterpolateInstr* instr) {
+ // TODO(srdjan): Remove the code below and enable constant folding once
+ // issue resolved.
+ SetValue(instr, non_constant_);
+ return;
+
if (IsNonConstant(instr->constant_value())) {
// Do not bother with costly analysis if we already know that the
// instruction is not a constant.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698