Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 27466002: Issue 14133. Tweak test. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, rmacnak
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tests/language/language_analyzer.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/malbounded_type_cast_test.dart View 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
scheglov
7 years, 2 months ago (2013-10-16 04:51:31 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-16 13:57:59 UTC) #2
rmacnak
+Regis, Johnni
7 years, 2 months ago (2013-10-16 16:53:12 UTC) #3
regis
LGTM
7 years, 2 months ago (2013-10-16 17:41:56 UTC) #4
Johnni Winther
lgtm
7 years, 2 months ago (2013-10-16 18:26:56 UTC) #5
regis
https://codereview.chromium.org/27466002/diff/1/tests/language/malbounded_type_cast_test.dart File tests/language/malbounded_type_cast_test.dart (right): https://codereview.chromium.org/27466002/diff/1/tests/language/malbounded_type_cast_test.dart#newcode27 tests/language/malbounded_type_cast_test.dart:27: Expect.throws(() => s as Malbounded1, expectedError); Actually, I take ...
7 years, 2 months ago (2013-10-16 18:46:28 UTC) #6
regis
https://codereview.chromium.org/27466002/diff/1/tests/language/malbounded_type_cast_test.dart File tests/language/malbounded_type_cast_test.dart (right): https://codereview.chromium.org/27466002/diff/1/tests/language/malbounded_type_cast_test.dart#newcode27 tests/language/malbounded_type_cast_test.dart:27: Expect.throws(() => s as Malbounded1, expectedError); On 2013/10/16 18:46:28, ...
7 years, 2 months ago (2013-10-16 18:58:32 UTC) #7
scheglov
7 years, 2 months ago (2013-10-16 19:16:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r28745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698