Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: tests/language/malbounded_type_cast_test.dart

Issue 27466002: Issue 14133. Tweak test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_analyzer.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/malbounded_type_cast_test.dart
diff --git a/tests/language/malbounded_type_cast_test.dart b/tests/language/malbounded_type_cast_test.dart
index 0b54850fed840856ff5b6f54dbe38e35af78c29f..26a8b11b5e8ae0f82428305f57b7f63411ecd938 100644
--- a/tests/language/malbounded_type_cast_test.dart
+++ b/tests/language/malbounded_type_cast_test.dart
@@ -11,7 +11,7 @@ class Malbounded2 extends Super<String> {} /// static type warning
main() {
bool inCheckedMode = false;
try {
- String a = 42;
+ String a = 42; /// static type warning
} catch (e) {
inCheckedMode = true;
}
@@ -24,7 +24,7 @@ main() {
}
var s = new Super<int>();
- Expect.throws(() => s as Malbounded1, expectedError); /// static type warning
- Expect.throws(() => s as Malbounded2, expectedError); /// static type warning
+ Expect.throws(() => s as Malbounded1, expectedError);
regis 2013/10/16 18:46:28 Actually, I take my LGTM back. s as Malbounded1 sh
regis 2013/10/16 18:58:32 Never mind, still LGTM. It will be a TypeError in
+ Expect.throws(() => s as Malbounded2, expectedError);
Expect.throws(() => s as Super<String>, expectedError); /// static type warning
}
« no previous file with comments | « tests/language/language_analyzer.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698