Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 27417002: fix PolymerElement.bind to call reflectPropertyToAttribute w/ prop name (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix PolymerElement.bind to call reflectPropertyToAttribute w/ prop name This is the fix for issue 14060 Polymer.js fix is at: https://github.com/Polymer/polymer/pull/319 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=28688

Patch Set 1 #

Patch Set 2 : update pkg.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1 line) Patch
M pkg/pkg.status View 1 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/polymer/test/prop_attr_bind_reflection_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
A pkg/polymer/test/prop_attr_bind_reflection_test.html View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-15 22:12:54 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 2 months ago (2013-10-15 22:16:24 UTC) #2
Jennifer Messerly
7 years, 2 months ago (2013-10-15 22:41:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28688 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698