pkg/polymer/lib/src/instance.dart - Issue 27417002: fix PolymerElement.bind to call reflectPropertyToAttribute w/ prop name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/lib/src/instance.dart

Issue 27417002: fix PolymerElement.bind to call reflectPropertyToAttribute w/ prop name (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: update pkg.status Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/lib/src/instance.dart

diff --git a/pkg/polymer/lib/src/instance.dart b/pkg/polymer/lib/src/instance.dart

index c96aca005444afcf639193422149cb25fb94ab80..dd5c349cbcc30649f669b12731c57902579adae5 100644

--- a/pkg/polymer/lib/src/instance.dart

+++ b/pkg/polymer/lib/src/instance.dart

@@ -394,7 +394,9 @@ abstract class Polymer implements Element {

// reflect bound property to attribute when binding

// to ensure binding is not left on attribute if property

// does not update due to not changing.

- reflectPropertyToAttribute(name);

+ // Dart note: we include this patch:

+ // https://github.com/Polymer/polymer/pull/319

+ reflectPropertyToAttribute(MirrorSystem.getName(property.simpleName));

return bindings[name] = observer;

} else {

// Cannot call super.bind because of

« no previous file with comments | « pkg/pkg.status ('k') | pkg/polymer/test/prop_attr_bind_reflection_test.dart » ('j') | no next file with comments »