Issue 27339003: When a value has been optimized away by the compiler, set its value to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27339003: When a value has been optimized away by the compiler, set its value to (Closed)

Created:
7 years, 2 months ago by turnidge

Modified:
7 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

When a value has been optimized away by the compiler, set its value to "<optimized out>". This will make it less confusing for people using the debugger. - Added constant_dead() to the flow graph. - Added Symbols::OptimizedOut(). R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=28671

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -12 lines)			Patch
M	runtime/vm/debugger_api_impl_test.cc	View	1 2 3 4	2 chunks	+6 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1	5 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

turnidge

Added a file to the cl. There is one debugger unit test which exercises this ...

7 years, 2 months ago (2013-10-15 18:24:27 UTC) #3

turnidge

Committed patchset #5 manually as r28671 (presubmit successful).

7 years, 2 months ago (2013-10-15 18:35:12 UTC) #4

Florian Schneider

7 years, 2 months ago (2013-10-16 13:03:32 UTC) #5

Message was sent while issue was closed.

On 2013/10/15 18:24:27, turnidge wrote:
> Added a file to the cl.  There is one debugger unit test which exercises this
> change.

LGTM as well.

Expand Messages | Collapse Messages