Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 27339003: When a value has been optimized away by the compiler, set its value to (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl_test.cc
===================================================================
--- runtime/vm/debugger_api_impl_test.cc (revision 28669)
+++ runtime/vm/debugger_api_impl_test.cc (working copy)
@@ -453,13 +453,10 @@
dart_args[1] = Dart_NewInteger(kLowThreshold);
EXPECT_VALID(Dart_Invoke(script_lib, NewString("test"), 2, dart_args));
if (optimize) {
- // Note that several variables have the value 'null' in the
- // optimized case. This is because these values were determined
- // to be dead by the optimizing compiler and their values were not
- // preserved by the deopt information.
EXPECT_STREQ("[0] breakpointNow { }\n"
- "[1] helper { a = 5 b = 99 stop = null }\n"
- "[2] anotherMiddleMan { one = null two = null stop = null }\n"
+ "[1] helper { a = 5 b = 99 stop = <optimized out> }\n"
+ "[2] anotherMiddleMan { one = <optimized out> "
+ "two = <optimized out> stop = <optimized out> }\n"
"[3] middleMan { x = 5 limit = 100 stop = true value = 24255"
" i = 99 }\n"
"[4] test { stop = true limit = 100 }\n",
@@ -549,10 +546,10 @@
EXPECT_VALID(Dart_Invoke(script_lib, NewString("test"), 2, dart_args));
if (optimize) {
EXPECT_STREQ("[0] breakpointNow { }\n"
- "[1] helper { a = 50 b = 99 stop = null }\n"
+ "[1] helper { a = 50 b = 99 stop = <optimized out> }\n"
"[2] <anonymous closure> { x = 5 i = 99 stop = true"
- " value = null }\n"
- "[3] anotherMiddleMan { func = null }\n"
+ " value = <optimized out> }\n"
+ "[3] anotherMiddleMan { func = <optimized out> }\n"
"[4] middleMan { x = 5 limit = 100 stop = true"
" value = 242550 i = 99 }\n"
"[5] test { stop = true limit = 100 }\n",
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698