Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 270593003: Don't build dart2js_bot on debug dart2js bots (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't build dart2js_bot on debug dart2js bots This is making the bots hit the 20 min timeout R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=35882

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M dart.gyp View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tools/bots/compiler.py View 1 2 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-07 12:08:22 UTC) #1
ricow1
Changed this to use a specific debug target Also, disable running the try testing in ...
6 years, 7 months ago (2014-05-07 12:49:13 UTC) #2
ahe
lgtm Dart2js_bot could depend on dart2js_bot_debug to reduce duplication.
6 years, 7 months ago (2014-05-07 13:15:14 UTC) #3
ricow1
6 years, 7 months ago (2014-05-08 06:49:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698