Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/bots/compiler.py

Issue 270593003: Don't build dart2js_bot on debug dart2js bots (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 35843)
+++ tools/bots/compiler.py (working copy)
@@ -281,11 +281,11 @@
extras_flags = extras_flags + ['--host-checked']
TestStep('dart2js_extra', mode, system, 'dart2js', runtime, extras,
extras_flags, arch)
+ if mode == 'release':
+ TestStep('try_dart', mode, system, 'dart2js', runtime, ['try'],
+ extras_flags, arch)
- TestStep('try_dart', mode, system, 'dart2js', runtime, ['try'],
- extras_flags, arch)
-
def GetHasHardCodedCheckedMode(build_info):
# TODO(ricow): We currently run checked mode tests on chrome on linux and
# on the slow (all) IE windows bots. This is a hack and we should use the
@@ -370,8 +370,13 @@
build and test to be run.
"""
with bot.BuildStep('Build SDK'):
+ target = 'dart2js_bot'
+ # Try-dart takes more than 20 min in debug mode and makes the bot time out.
+ # We use the debug target which does not include try
+ if build_info.mode == 'debug':
+ target = 'dart2js_bot_debug'
args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
- '--arch=' + build_info.arch, 'dart2js_bot']
+ '--arch=' + build_info.arch, target]
print 'Build SDK and d8: %s' % (' '.join(args))
bot.RunProcess(args)
« no previous file with comments | « dart.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698