Issue 269443002: Only assume that we have 32 D registers on ARMv7-a.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269443002: Only assume that we have 32 D registers on ARMv7-a. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Only assume that we have 32 D registers on ARMv7-a. Otherwise assume that there are 16. Since we must know the number of VFP registers on ARM when the VM is compiled, we infer the number from predefined macros of the compiler. This CL also disables vmov{d,s} of an immediate unless we are on ARMv7. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35578

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -7 lines)			Patch
	M	runtime/vm/assembler_arm.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	runtime/vm/constants_arm.h	View	1 2 3	8 chunks	+43 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

6 years, 7 months ago (2014-04-30 17:27:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r35578 (presubmit successful).

Expand Messages | Collapse Messages