Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 269153003: Fix position of error messages. (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, lukechurch, Johnni Winther
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r35883. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M dart/site/try/index.html View 3 chunks +3 lines, -6 lines 0 comments Download
M dart/site/try/src/interaction_manager.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M dart/site/try/src/ui.dart View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
Don't know how to test this.
6 years, 7 months ago (2014-05-06 13:06:58 UTC) #1
kasperl
LGTM.
6 years, 7 months ago (2014-05-06 13:08:35 UTC) #2
ahe
6 years, 7 months ago (2014-05-08 07:29:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698