dart/site/try/src/interaction_manager.dart - Issue 269153003: Fix position of error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/site/try/src/interaction_manager.dart

Issue 269153003: Fix position of error messages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged with r35883. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/site/try/src/interaction_manager.dart

diff --git a/dart/site/try/src/interaction_manager.dart b/dart/site/try/src/interaction_manager.dart

index 4d4dd24d06b7b0a7e121b040d4895eae4d6983b6..277b2a813d9e6905b2389661eeea99a566b51edc 100644

--- a/dart/site/try/src/interaction_manager.dart

+++ b/dart/site/try/src/interaction_manager.dart

@@ -873,11 +873,6 @@ Node findLine(Node node) {

}

Element makeLine(List<Node> lineNodes, String state) {

- // Using a div element here (anything with display=block) generally messes up

- // editing and navigation. We would like to use a block element here so

- // error messages show as expected. But no such luck. Fortunately, there

- // are strong indications that the current solution for displaying errors

- // isn't good enough anyways.

return new SpanElement()

..setAttribute('dart-state', state)

..nodes.addAll(lineNodes)

« no previous file with comments | « dart/site/try/index.html ('k') | dart/site/try/src/ui.dart » ('j') | no next file with comments »