Issue 269003002: Fix crash in raw_secure_server_socket_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269003002: Fix crash in raw_secure_server_socket_test. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen

Modified:
6 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix crash in raw_secure_server_socket_test. We had a scenario where read&write events were requested after the socket was closed, leading to a use-after-free. This also fixes a scenario where we didn't delete client sockets, when accepted sockets are ignored when closing a listening socket. BUG=https://code.google.com/p/dart/issues/detail?id=18610 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35732

Patch Set 1 #

Patch Set 2 : Fix status file. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
M	runtime/bin/eventhandler_win.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_win.cc	View		6 chunks	+16 lines, -11 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

6 years, 7 months ago (2014-05-05 09:17:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35732 (presubmit successful).

Expand Messages | Collapse Messages