Fix crash in raw_secure_server_socket_test.

runtime/bin/eventhandler_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/eventhandler.h"
 
 #include <winsock2.h>  // NOLINT
@@ skipping 316 matching lines @@
 }
 
 
 bool Handle::IssueSendTo(struct sockaddr* sa, socklen_t sa_len) {
   return false;
 }
 
 
 void Handle::HandleIssueError() {
   DWORD error = GetLastError();
+  ASSERT(event_handler_ != NULL);
   if (error == ERROR_BROKEN_PIPE) {
     event_handler_->HandleClosed(this);
   } else {
     event_handler_->HandleError(this);
   }
   SetLastError(error);
 }
 
 
 void FileHandle::EnsureInitialized(EventHandlerImplementation* event_handler) {
@@ skipping 45 matching lines @@
     pending_read_ = buffer;
     return true;
   }
   OverlappedBuffer::DisposeBuffer(buffer);
   return false;
 }
 
 
 void SocketHandle::HandleIssueError() {
   int error = WSAGetLastError();
+  ASSERT(event_handler_ != NULL);
   if (error == WSAECONNRESET) {
     event_handler_->HandleClosed(this);
   } else {
     event_handler_->HandleError(this);
   }
   WSASetLastError(error);
 }
 
 
 bool ListenSocket::LoadAcceptEx() {
@@ skipping 83 matching lines @@
   } else {
     // Close the socket, as it's already accepted.
     closesocket(buffer->client());
   }
 
   pending_accept_count_--;
   OverlappedBuffer::DisposeBuffer(buffer);
 }
 
 
+static void DeleteIfClosed(Handle* handle) {
+  if (handle->IsClosed()) {
+    Dart_Port port = handle->port();
+    delete handle;
+    if (port != ILLEGAL_PORT) {
+      DartUtils::PostInt32(port, 1 << kDestroyedEvent);
+    }
+  }
+}
+
+
 void ListenSocket::DoClose() {
   closesocket(socket());
   handle_ = INVALID_HANDLE_VALUE;
   while (CanAccept()) {
     // Get rid of connections already accepted.
     ClientSocket *client = Accept();
     if (client != NULL) {
       client->Close();
+      DeleteIfClosed(client);
     } else {
       break;
     }
   }
 }
 
 
 bool ListenSocket::CanAccept() {
   ScopedLock lock(this);
   return accepted_head_ != NULL;
@@ skipping 425 matching lines @@
 
 
 void DatagramSocket::DoClose() {
   // Just close the socket. This will cause any queued requests to be aborted.
   closesocket(socket());
   MarkClosedRead();
   MarkClosedWrite();
 }
 
 
-static void DeleteIfClosed(Handle* handle) {
-  if (handle->IsClosed()) {
-    Dart_Port port = handle->port();
-    delete handle;
-    if (port != ILLEGAL_PORT) {
-      DartUtils::PostInt32(port, 1 << kDestroyedEvent);
-    }
-  }
-}
-
-
 void EventHandlerImplementation::HandleInterrupt(InterruptMessage* msg) {
+  ASSERT(this != NULL);
   if (msg->id == kTimeoutId) {
     // Change of timeout request. Just set the new timeout and port as the
     // completion thread will use the new timeout value for its next wait.
     timeout_queue_.UpdateTimeout(msg->dart_port, msg->data);
   } else if (msg->id == kShutdownId) {
     shutdown_ = true;
   } else {
     // No tokens to return on Windows.
     if ((msg->data & (1 << kReturnTokenCommand)) != 0) return;
     Handle* handle = reinterpret_cast<Handle*>(msg->id);
@@ skipping 302 matching lines @@
     OVERLAPPED* overlapped;
     int64_t millis = handler_impl->GetTimeout();
     ASSERT(millis == kInfinityTimeout || millis >= 0);
     if (millis > kMaxInt32) millis = kMaxInt32;
     ASSERT(sizeof(int32_t) == sizeof(DWORD));
     BOOL ok = GetQueuedCompletionStatus(handler_impl->completion_port(),
                                         &bytes,
                                         &key,
                                         &overlapped,
                                         static_cast<DWORD>(millis));
+
     if (!ok && overlapped == NULL) {
       if (GetLastError() == ERROR_ABANDONED_WAIT_0) {
         // The completion port should never be closed.
         Log::Print("Completion port closed\n");
         UNREACHABLE();
       } else {
         // Timeout is signalled by false result and NULL in overlapped.
         handler_impl->HandleTimeout();
       }
     } else if (!ok) {
@@ skipping 41 matching lines @@
 
 
 void EventHandlerImplementation::Shutdown() {
   SendData(kShutdownId, 0, 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)