Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 26900005: Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type… (Closed)

Created:
7 years, 2 months ago by zarah
Modified:
7 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable.". This reverts r28717. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=28726

Patch Set 1 #

Patch Set 2 : Fix: stop ignoring classes not needed for reflection when processing type variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -42 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 6 chunks +18 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 3 chunks +7 lines, -6 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart View 1 1 chunk +143 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 2 chunks +12 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 5 chunks +17 lines, -11 lines 0 comments Download
M sdk/lib/_internal/lib/js_rti.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/lib/mirrors/class_mirror_type_variables_test.dart View 2 chunks +38 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zarah
7 years, 2 months ago (2013-10-16 14:56:30 UTC) #1
ahe
lgtm
7 years, 2 months ago (2013-10-16 14:58:03 UTC) #2
zarah
Committed patchset #2 manually as r28726 (presubmit successful).
7 years, 2 months ago (2013-10-16 15:15:23 UTC) #3
zarah
7 years, 2 months ago (2013-10-16 15:15:28 UTC) #4
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698