sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart - Issue 26900005: Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

Issue 26900005: Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix: stop ignoring classes not needed for reflection when processing type variables. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

index f4597f3b9946389ee7dedb5a424331c19a09c13a..162272eb588f82408c3c81541c1ac5f95e90bd7f 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

@@ -70,9 +70,14 @@ class MetadataEmitter extends CodeEmitterHelper {

}

int reifyType(DartType type) {

- // TODO(ahe): Handle type variables correctly instead of using "#".

- String representation = backend.rti.getTypeRepresentation(type, (_) {});

- return addGlobalMetadata(representation.replaceAll('#', 'null'));

+ jsAst.Expression representation =

+ backend.rti.getTypeRepresentation(type, (variable) {

+ return js.toExpression(

+ task.typeVariableHandler.reifyTypeVariable(variable.element));

+ });

+ return addGlobalMetadata(

+ jsAst.prettyPrint(representation, compiler).getText());

}

int reifyName(SourceString name) {