Issue 268673021: Adds assert to mips assembler macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268673021: Adds assert to mips assembler macros. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Adds assert to mips assembler macros. The asserts prevent trying to put macros in the branch delay slot. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35912

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -0 lines)			Patch
	M	runtime/vm/assembler_mips.h	View		23 chunks	+39 lines, -0 lines	0 comments	Download
	M	runtime/vm/assembler_mips.cc	View		35 chunks	+35 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

zra

6 years, 7 months ago (2014-05-08 14:41:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35912 (presubmit successful).