Issue 26800008: Force resolution on metadata of static members

Issue 26800008: Force resolution on metadata of static members (Closed)

Created:
7 years, 2 months ago by sra1

Modified:
7 years, 2 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org, dgrove

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Force resolution on metadata of static members R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28847

Patch Set 2 : Add test and narrow eager resolution #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
	A	tests/lib/mirrors/static_metatarget_test.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

As noted in my email, I'm not sure that this fixes the whole problem, but ...

7 years, 2 months ago (2013-10-18 00:17:44 UTC) #1

kasperl

LGTM. https://codereview.chromium.org/26800008/diff/15001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/26800008/diff/15001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode741 sdk/lib/_internal/compiler/implementation/resolution/members.dart:741: // inspected by the backend while emitting. Maybe ...

7 years, 2 months ago (2013-10-18 08:53:07 UTC) #2

Johnni Winther

https://codereview.chromium.org/26800008/diff/15001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/26800008/diff/15001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode741 sdk/lib/_internal/compiler/implementation/resolution/members.dart:741: // inspected by the backend while emitting. On 2013/10/18 ...

7 years, 2 months ago (2013-10-18 09:09:00 UTC) #3

Johnni Winther

7 years, 2 months ago (2013-10-18 09:16:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r28847 (presubmit successful).

Expand Messages | Collapse Messages