Force resolution on metadata of static members

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element get currentElement;
   Setlet<Node> get superUses;
 
@@ skipping 718 matching lines @@
       // Stepwise assignment to ensure invariant.
       element.supertypeLoadState = STATE_STARTED;
       element.supertypeLoadState = STATE_DONE;
       element.resolutionState = STATE_DONE;
       // TODO(johnniwinther): Check matching type variables and
       // empty extends/implements clauses.
     }
     for (MetadataAnnotation metadata in element.metadata) {
       metadata.ensureResolved(compiler);
     }
+
+    // Force resolution of metadata on non-instance members since they may be
+    // inspected by the backend while emitting.

[kasperl, 2013/10/18 08:53:07]

Maybe update the comment so it's clear where we deal with the instance members?

[Johnni Winther, 2013/10/18 09:09:00]

Done.

+    // TODO(ahe): Avoid this eager resolution.
+    element.forEachMember((_, Element member) {
+      if (!member.isInstanceMember()) {
+        compiler.withCurrentElement(member, () {
+          for (MetadataAnnotation metadata in member.metadata) {
+            metadata.ensureResolved(compiler);
+          }
+        });
+      }
+    });
+

[kasperl, 2013/10/18 08:53:07]

Remove newline.

[Johnni Winther, 2013/10/18 09:09:00]

Done.

   }
 
   void checkClass(ClassElement element) {
     if (element.isMixinApplication) {
       checkMixinApplication(element);
     } else {
       checkClassMembers(element);
     }
   }
 
@@ skipping 3911 matching lines @@
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }
 
 /// Looks up [name] in [scope] and unwraps the result.
 Element lookupInScope(Compiler compiler, Node node,
                       Scope scope, SourceString name) {
   return Elements.unwrap(scope.lookup(name), compiler, node);
 }