Add support for catching rendere crashes in drt

Add support for catching rendere crashes in drt

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28443

[kustermann, 2013-10-10 08:55:22]

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:821: return super.hasCrashed ||
_rendereCrashed;
If you commit this change as it is now, it will likely make our bots red.
You have to run it locally, and make status file changes from
  [ $runtime == drt ]
  abc_test: Fail
to
  [ $runtime == drt ]
  abc_test: Crash

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:859: bool get _rendereCrashed {
_rendereCrashed => _rendererCrashed

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:860: var stdoutLines =
decodeUtf8(super.stdout).split("\n");
Is this really in stdout (and not in stderr)?

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:863: }
I think it would be faster and equally good, to just say:

bool get _rendererCrashed => decodeUtf8(stdout).contains("#CRASHED - render")

[ricow1, 2013-10-10 09:26:49]

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:821: return super.hasCrashed ||
_rendereCrashed;
On 2013/10/10 08:55:22, kustermann wrote:
> If you commit this change as it is now, it will likely make our bots red.
> You have to run it locally, and make status file changes from
>   [ $runtime == drt ]
>   abc_test: Fail
> to
>   [ $runtime == drt ]
>   abc_test: Crash
They are red - very red. 
There are no tests outside cc tests that are marked as crashing on the VM, i.e.,
there should be nothing else crashing like this! (except those for issue 13808
and 13952, these are already marked genericly as crashing on compiler==none)

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:859: bool get _rendereCrashed {
On 2013/10/10 08:55:22, kustermann wrote:
> _rendereCrashed => _rendererCrashed

Done.

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:860: var stdoutLines =
decodeUtf8(super.stdout).split("\n");
On 2013/10/10 08:55:22, kustermann wrote:
> Is this really in stdout (and not in stderr)?

It is in both

https://codereview.chromium.org/26793004/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:863: }
On 2013/10/10 08:55:22, kustermann wrote:
> I think it would be faster and equally good, to just say:
> 
> bool get _rendererCrashed => decodeUtf8(stdout).contains("#CRASHED - render")

Done.

[kustermann, 2013-10-10 09:30:15]

LGTM

[ricow1, 2013-10-10 09:30:57]

Committed patchset #2 manually as r28443 (presubmit successful).