Fixing double-completing indexed DB transactions

Fixing double-completing indexed DB transactions

Basically when an error occurs, aborted occurs as well, causing an error because the future was being completed more than once.

BUG=11405
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28770

[Emily Fortuna, 2013-10-16 00:20:59]

https://codereview.chromium.org/26789008/diff/8001/sdk/lib/indexed_db/dart2js...
File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right):

https://codereview.chromium.org/26789008/diff/8001/sdk/lib/indexed_db/dart2js...
sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:1268: if (!errored) {
would completer.isCompleted work instead?

[Emily Fortuna, 2013-10-16 00:21:24]

lgtm though, just see if my comment works first please.

[blois, 2013-10-17 01:05:06]

https://codereview.chromium.org/26789008/diff/8001/sdk/lib/indexed_db/dart2js...
File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right):

https://codereview.chromium.org/26789008/diff/8001/sdk/lib/indexed_db/dart2js...
sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:1268: if (!errored) {
On 2013/10/16 00:20:59, Emily Fortuna wrote:
> would completer.isCompleted work instead?

Ah, much nicer!

[Emily Fortuna, 2013-10-17 01:06:55]

lgtm

[blois, 2013-10-17 01:07:22]

Committed patchset #2 manually as r28770 (presubmit successful).