Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: tools/dom/templates/html/impl/impl_IDBTransaction.darttemplate

Issue 26789008: Fixing double-completing indexed DB transactions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC { 7 $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
8 8
9 /** 9 /**
10 * Provides a Future which will be completed once the transaction has 10 * Provides a Future which will be completed once the transaction has
11 * completed. 11 * completed.
12 * 12 *
13 * The future will error if an error occurrs on the transaction or if the 13 * The future will error if an error occurrs on the transaction or if the
14 * transaction is aborted. 14 * transaction is aborted.
15 */ 15 */
16 Future<Database> get completed { 16 Future<Database> get completed {
17 var completer = new Completer<Database>(); 17 var completer = new Completer<Database>();
18 18
19 this.onComplete.first.then((_) { 19 this.onComplete.first.then((_) {
20 completer.complete(db); 20 completer.complete(db);
21 }); 21 });
22 22
23 this.onError.first.then((e) { 23 this.onError.first.then((e) {
24 completer.completeError(e); 24 completer.completeError(e);
25 }); 25 });
26 26
27 this.onAbort.first.then((e) { 27 this.onAbort.first.then((e) {
28 completer.completeError(e); 28 // Avoid completing twice if an error occurs.
29 if (!completer.isCompleted) {
30 completer.completeError(e);
31 }
29 }); 32 });
30 33
31 return completer.future; 34 return completer.future;
32 } 35 }
33 36
34 $!MEMBERS 37 $!MEMBERS
35 } 38 }
OLDNEW
« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698