Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 267793005: Use xorps xmm1, xmm1 to creat a 0.0 cconstant. Add to utils a bitwise double test. (Closed)

Created:
6 years, 7 months ago by srdjan
Modified:
6 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use xorps xmm1, xmm1 to creat a 0.0 cconstant. Add to utils a bitwise double test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=35718

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M runtime/platform/utils.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/utils_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
6 years, 7 months ago (2014-05-02 23:12:14 UTC) #1
zra
You can do the same on ARM with the veorq instruction. https://codereview.chromium.org/267793005/diff/1/runtime/platform/utils.h File runtime/platform/utils.h (right): ...
6 years, 7 months ago (2014-05-02 23:19:08 UTC) #2
srdjan
Added veorq to ARM https://codereview.chromium.org/267793005/diff/1/runtime/platform/utils.h File runtime/platform/utils.h (right): https://codereview.chromium.org/267793005/diff/1/runtime/platform/utils.h#newcode184 runtime/platform/utils.h:184: const int64_t* a_i = reinterpret_cast<const ...
6 years, 7 months ago (2014-05-02 23:33:47 UTC) #3
zra
lgtm
6 years, 7 months ago (2014-05-02 23:48:16 UTC) #4
srdjan
6 years, 7 months ago (2014-05-02 23:50:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r35718 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698