runtime/vm/intermediate_language_x64.cc - Issue 267793005: Use xorps xmm1, xmm1 to creat a 0.0 cconstant. Add to utils a bitwise double test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 267793005: Use xorps xmm1, xmm1 to creat a 0.0 cconstant. Add to utils a bitwise double test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

===================================================================

--- runtime/vm/intermediate_language_x64.cc (revision 35714)

+++ runtime/vm/intermediate_language_x64.cc (working copy)

@@ -242,8 +242,12 @@

// The register allocator drops constant definitions that have no uses.

if (!locs()->out(0).IsInvalid()) {

XmmRegister result = locs()->out(0).fpu_reg();

- __ LoadObject(TMP, value(), PP);

- __ movsd(result, FieldAddress(TMP, Double::value_offset()));

+ if (Utils::DoublesBitEqual(Double::Cast(value()).value(), 0.0)) {

+ __ xorps(result, result);

+ } else {

+ __ LoadObject(TMP, value(), PP);

+ __ movsd(result, FieldAddress(TMP, Double::value_offset()));

+ }

}

« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/utils_test.cc » ('j') | no next file with comments »