Issue 267353005: - Change when the library being loaded is registered. Now

Issue 267353005: - Change when the library being loaded is registered. Now (Closed)

Created:
6 years, 7 months ago by Ivan Posva

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Change when the library being loaded is registered. Now we register it before calling the tag handler so that the VM can keep track of which libraries have outstanding requests. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=35870

Patch Set 1 #

Total comments: 3

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -20 lines)			Patch
M	runtime/bin/builtin.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/builtin.cc	View	2 chunks	+18 lines, -12 lines	0 comments	Download
M	runtime/bin/builtin_nolib.cc	View	1 chunk	+6 lines, -0 lines	3 comments	Download
M	runtime/bin/dartutils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc File runtime/bin/builtin_nolib.cc (right): https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc#newcode58 runtime/bin/builtin_nolib.cc:58: "Unreachable code in Builtin::LoadLibrary (%d).", id); No space ...

6 years, 7 months ago (2014-05-07 20:06:19 UTC) #2

Ivan Posva

Thanks! -Ivan https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc File runtime/bin/builtin_nolib.cc (right): https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc#newcode58 runtime/bin/builtin_nolib.cc:58: "Unreachable code in Builtin::LoadLibrary (%d).", id); On ...

6 years, 7 months ago (2014-05-07 21:45:46 UTC) #3

Ivan Posva

Committed patchset #1 manually as r35870 (presubmit successful).

6 years, 7 months ago (2014-05-07 21:46:09 UTC) #4

hausner

6 years, 7 months ago (2014-05-07 21:56:46 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc
File runtime/bin/builtin_nolib.cc (right):

https://codereview.chromium.org/267353005/diff/1/runtime/bin/builtin_nolib.cc...
runtime/bin/builtin_nolib.cc:58: "Unreachable code in Builtin::LoadLibrary
(%d).", id);
On 2014/05/07 21:45:46, Ivan Posva wrote:
> On 2014/05/07 20:06:19, hausner wrote:
> > No space before (%d)
> 
> The space is needed if you do "XYZ (%" Pd " ).", but not here where a space
> would change the formatting of the output.

What I mean is:

"Unreachable code in Builtin::LoadLibrary(%d)."

No space between y and (.

Expand Messages | Collapse Messages