Issue 26734004: use symbol literals instead of const ctor in packages

Issue 26734004: use symbol literals instead of const ctor in packages (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

use symbol literals instead of const ctor R=rnystrom@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=28485

Patch Set 5 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -232 lines)			Patch
M	pkg/mdv/test/custom_element_bindings_test.dart	View		5 chunks	+16 lines, -18 lines	0 comments	Download
M	pkg/mdv/test/element_bindings_test.dart	View		17 chunks	+39 lines, -41 lines	0 comments	Download
M	pkg/mdv/test/mdv_test_utils.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/mdv/test/node_bindings_test.dart	View		6 chunks	+16 lines, -18 lines	0 comments	Download
M	pkg/mdv/test/template_element_test.dart	View	1 2	25 chunks	+45 lines, -48 lines	0 comments	Download
M	pkg/observe/lib/html.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/observe/lib/observe.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/observe/lib/src/bind_property.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/observe/lib/src/change_notifier.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/observe/lib/src/compound_binding.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/observe/lib/src/list_path_observer.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/observe/lib/src/observable_box.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/observe/lib/src/observable_list.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/observe/lib/src/observable_map.dart	View		5 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/observe/lib/src/path_observer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/observe/test/observable_list_test.dart	View	1 2	3 chunks	+2 lines, -6 lines	0 comments	Download
M	pkg/observe/test/observable_map_test.dart	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	pkg/observe/test/observe_test.dart	View		5 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/observe/test/path_observer_test.dart	View		8 chunks	+19 lines, -21 lines	0 comments	Download
M	pkg/path/lib/path.dart	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/polymer/lib/deserialize.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/polymer/lib/src/declaration.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	pkg/polymer/lib/src/instance.dart	View	1 2 3 4	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/polymer/lib/src/loader.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer_expressions/example/person.dart	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	pkg/polymer_expressions/lib/polymer_expressions.dart	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer_expressions/lib/src/mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer_expressions/test/eval_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/polymer_expressions/test/syntax_test.dart	View		3 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Bob, do you mind looking at "path" changes? Siggi, do you mind looking at the ...

7 years, 2 months ago (2013-10-10 21:11:57 UTC) #1

Siggi Cherem (dart-lang)

lgtm (except for that one line below) https://codereview.chromium.org/26734004/diff/3001/pkg/observe/test/observable_list_test.dart File pkg/observe/test/observable_list_test.dart (right): https://codereview.chromium.org/26734004/diff/3001/pkg/observe/test/observable_list_test.dart#newcode257 pkg/observe/test/observable_list_test.dart:257: const #length ...

7 years, 2 months ago (2013-10-10 21:31:11 UTC) #3

Jennifer Messerly

https://codereview.chromium.org/26734004/diff/3001/pkg/observe/test/observable_list_test.dart File pkg/observe/test/observable_list_test.dart (right): https://codereview.chromium.org/26734004/diff/3001/pkg/observe/test/observable_list_test.dart#newcode257 pkg/observe/test/observable_list_test.dart:257: const #length = #length; On 2013/10/10 21:31:11, Siggi Cherem ...

7 years, 2 months ago (2013-10-10 22:39:43 UTC) #4

Jennifer Messerly

7 years, 2 months ago (2013-10-10 22:55:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r28485 (presubmit successful).

Expand Messages | Collapse Messages