pkg/observe/lib/src/change_notifier.dart - Issue 26734004: use symbol literals instead of const ctor in packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/observe/lib/src/change_notifier.dart

Issue 26734004: use symbol literals instead of const ctor in packages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/observe/lib/src/change_notifier.dart

diff --git a/pkg/observe/lib/src/change_notifier.dart b/pkg/observe/lib/src/change_notifier.dart

index 8102ab0c7110b3ca5f2f4bdafb197e7360e32c0d..b5e97072c1ee09b1e215f26f5f12f1aa0812c05a 100644

--- a/pkg/observe/lib/src/change_notifier.dart

+++ b/pkg/observe/lib/src/change_notifier.dart

@@ -73,8 +73,7 @@ abstract class ChangeNotifierMixin implements Observable {

* var _myField;

* get myField => _myField;

* set myField(value) {

- * _myField = notifyPropertyChange(

- * const Symbol('myField'), _myField, value);

+ * _myField = notifyPropertyChange(#myField, _myField, value);

* }

notifyPropertyChange(Symbol field, Object oldValue, Object newValue)

« no previous file with comments | « pkg/observe/lib/src/bind_property.dart ('k') | pkg/observe/lib/src/compound_binding.dart » ('j') | no next file with comments »