Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 266723012: Move the double isNegative test back to double.cc as it seems to cause some compile issues when it … (Closed)

Created:
6 years, 7 months ago by siva
Modified:
6 years, 7 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Move the double isNegative test back to double.cc as it seems to cause some compile issues when it is in object.h R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=35695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M runtime/lib/double.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.h View 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
6 years, 7 months ago (2014-05-02 16:22:54 UTC) #1
zra
lgtm
6 years, 7 months ago (2014-05-02 16:23:43 UTC) #2
siva
Committed patchset #1 manually as r35695 (presubmit successful).
6 years, 7 months ago (2014-05-02 16:50:07 UTC) #3
srdjan
6 years, 7 months ago (2014-05-02 16:54:10 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698