Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: runtime/vm/object.h

Issue 266723012: Move the double isNegative test back to double.cc as it seems to cause some compile issues when it … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/double.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 35690)
+++ runtime/vm/object.h (working copy)
@@ -5,8 +5,6 @@
#ifndef VM_OBJECT_H_
#define VM_OBJECT_H_
-#include <math.h>
-
#include "include/dart_api.h"
#include "platform/assert.h"
#include "platform/utils.h"
@@ -4797,11 +4795,6 @@
class Number : public Instance {
public:
// TODO(iposva): Fill in a useful Number interface.
- virtual bool IsNegative() const {
- // Number is an abstract class.
- UNREACHABLE();
- return false;
- }
private:
OBJECT_IMPLEMENTATION(Number, Instance);
@@ -4828,6 +4821,11 @@
UNREACHABLE();
return false;
}
+ virtual bool IsNegative() const {
+ // Number is an abstract class.
+ UNREACHABLE();
+ return false;
+ }
virtual double AsDoubleValue() const;
virtual int64_t AsInt64Value() const;
virtual uint32_t AsTruncatedUint32Value() const;
@@ -5084,10 +5082,6 @@
bool EqualsToDouble(double value) const;
virtual bool Equals(const Instance& other) const;
- virtual bool IsNegative() const {
- double dval = value();
- return (signbit(dval) && !isnan(dval));
- }
static RawDouble* New(double d, Heap::Space space = Heap::kNew);
« no previous file with comments | « runtime/lib/double.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698