Make Try Dart tests run on Firefox.

Make Try Dart tests run on Firefox.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35788

[kasperl, 2014-05-06 04:42:22]

LGTM!

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart
File dart/site/try/src/cache.dart (right):

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart...
dart/site/try/src/cache.dart:24:
window.applicationCache.onUpdateReady.listen((_) => updateCacheStatus());
Consider having a local helper function for the (_) => updateCacheStatus() part.

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart...
dart/site/try/src/cache.dart:34: onCacheProgress(Event event) {
I'd add a void here -- if nothing else then for consistency.

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/selection....
File dart/site/try/src/selection.dart (right):

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/selection....
dart/site/try/src/selection.dart:26: : this.anchorNode = isCollapsed(selection)
? selection.anchorNode : null,
You could get rid of the 'this.' prefixes here (this.anchorNode,
this.anchorOffset).

https://codereview.chromium.org/266293002/diff/1/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/266293002/diff/1/dart/tests/try/try.status#ne...
dart/tests/try/try.status:5: # Not dart2js on chrome or drt.
Update comment. Maybe it's time to negate the condition so we only skip on
specific browsers?

[ahe, 2014-05-06 08:10:16]

Thank you, Kasper!

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart
File dart/site/try/src/cache.dart (right):

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart...
dart/site/try/src/cache.dart:24:
window.applicationCache.onUpdateReady.listen((_) => updateCacheStatus());
On 2014/05/06 04:42:22, kasperl wrote:
> Consider having a local helper function for the (_) => updateCacheStatus()
part.

I've changed updateCacheStatus to take an argument.

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/cache.dart...
dart/site/try/src/cache.dart:34: onCacheProgress(Event event) {
On 2014/05/06 04:42:22, kasperl wrote:
> I'd add a void here -- if nothing else then for consistency.

Done.

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/selection....
File dart/site/try/src/selection.dart (right):

https://codereview.chromium.org/266293002/diff/1/dart/site/try/src/selection....
dart/site/try/src/selection.dart:26: : this.anchorNode = isCollapsed(selection)
? selection.anchorNode : null,
On 2014/05/06 04:42:22, kasperl wrote:
> You could get rid of the 'this.' prefixes here (this.anchorNode,
> this.anchorOffset).

Done.

https://codereview.chromium.org/266293002/diff/1/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/266293002/diff/1/dart/tests/try/try.status#ne...
dart/tests/try/try.status:5: # Not dart2js on chrome or drt.
On 2014/05/06 04:42:22, kasperl wrote:
> Update comment. Maybe it's time to negate the condition so we only skip on
> specific browsers?

I like how it is now as I'm explicitly listing supported configurations.

I've updated the comment.

[ahe, 2014-05-06 08:14:29]

Committed patchset #3 manually as r35788 (presubmit successful).