Make Try Dart tests run on Firefox.

dart/site/try/src/cache.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library trydart.cache;
 
 import 'dart:async' show
     Timer;
 
 import 'dart:html' show
     AnchorElement,
     ApplicationCache,
     Event,
     MeterElement,
     ProgressEvent,
     window;
 
 import 'ui.dart' show
     cacheStatusElement;
 
 /// Called when the window has finished loading.
 void onLoad(Event event) {
+  if (!ApplicationCache.supported) return;
   window.applicationCache.onUpdateReady.listen((_) => updateCacheStatus());

[kasperl, 2014/05/06 04:42:22]

Consider having a local helper function for the (_) => updateCacheStatus() part.

[ahe, 2014/05/06 08:10:16]

I've changed updateCacheStatus to take an argument.

   window.applicationCache.onCached.listen((_) => updateCacheStatus());
   window.applicationCache.onChecking.listen((_) => updateCacheStatus());
   window.applicationCache.onDownloading.listen((_) => updateCacheStatus());
   window.applicationCache.onError.listen((_) => updateCacheStatus());
   window.applicationCache.onNoUpdate.listen((_) => updateCacheStatus());
   window.applicationCache.onObsolete.listen((_) => updateCacheStatus());
   window.applicationCache.onProgress.listen(onCacheProgress);
 }
 
-onCacheProgress(ProgressEvent event) {
-  if (!event.lengthComputable) {
-    updateCacheStatus();
-    return;
+onCacheProgress(Event event) {

[kasperl, 2014/05/06 04:42:22]

I'd add a void here -- if nothing else then for consistency.

[ahe, 2014/05/06 08:10:16]

Done.

+  if (event is ProgressEvent) {
+    // Firefox doesn't fire a ProgressEvent on cache progress.  Just a plain
+    // Event with type == "progress".
+    if (event.lengthComputable) {
+      updateCacheStatusFromEvent(event);
+      return;
+    }
   }
+  updateCacheStatus();
+}
+
+void updateCacheStatusFromEvent(ProgressEvent event) {
   cacheStatusElement.nodes.clear();
   cacheStatusElement.appendText('Downloading SDK ');
   var progress = '${event.loaded} of ${event.total}';
   if (MeterElement.supported) {
     cacheStatusElement.append(
         new MeterElement()
             ..appendText(progress)
             ..min = 0
             ..max = event.total
             ..value = event.loaded);
@@ skipping 30 matching lines @@
   } else if (status == ApplicationCache.IDLE) {
     cacheStatusElement.appendText(cacheStatus());
     cacheStatusElement.classes.add('offlineyay');
     new Timer(const Duration(seconds: 10), () {
       cacheStatusElement.style.display = 'none';
     });
   } else {
     cacheStatusElement.appendText(cacheStatus());
   }
 }