Issue 265853003: $-indexed printf params don't work on all of our architectures, turns out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265853003: $-indexed printf params don't work on all of our architectures, turns out. (Closed)

Created:
6 years, 7 months ago by turnidge

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

$-indexed printf params don't work on all of our architectures, turns out. Also, cleanup last fix a bit. Committed: https://code.google.com/p/dart/source/detail?r=35655

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -48 lines)			Patch
	M	runtime/vm/object.cc	View		2 chunks	+49 lines, -44 lines	0 comments	Download
	M	runtime/vm/parser_test.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

turnidge

Committed patchset #2 manually as r35655 (presubmit successful).

6 years, 7 months ago (2014-05-01 20:03:22 UTC) #2

Message was sent while issue was closed.

LGTM and more readable.