Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: runtime/vm/parser_test.cc

Issue 265853003: $-indexed printf params don't work on all of our architectures, turns out. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser_test.cc
diff --git a/runtime/vm/parser_test.cc b/runtime/vm/parser_test.cc
index a065f74bf13aa30c88cff4984427b01771eaf7d4..0cececf39077a66bb2287487101990f30fa6ce0b 100644
--- a/runtime/vm/parser_test.cc
+++ b/runtime/vm/parser_test.cc
@@ -212,13 +212,12 @@ static void SaveVars(Dart_IsolateId isolate_id,
for (intptr_t i = 0; i < num_frames; i++) {
ActivationFrame* frame = stack->FrameAt(i);
var_desc = frame->code().var_descriptors();
- const char* var_str = var_desc.ToCString();
- char* edited_var_str = SkipIndex(var_str);
+ const char* var_str = SkipIndex(var_desc.ToCString());
pos += OS::SNPrint(pos, (kBufferLen - (pos - buffer)),
"%s\n%s",
frame->function().ToQualifiedCString(),
- (edited_var_str != NULL ? edited_var_str :var_str));
- delete [] edited_var_str;
+ var_str);
+ delete [] var_str;
}
pos[0] = '\0';
saved_vars = buffer;
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698