Fiddle with breakpoint resolution

Fiddle with breakpoint resolution

CL  https://codereview.chromium.org/233973003 fixed resolving breakpoints in code that was out of order from a compiled code address perspective, but it introduced a regression. It was no longer possible to set a breakpoint on a line that has no executable code, for example the function header. This change fixes that, and hopefully doesn’t cause any other undesirable surprises in breakpoint setting.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35749

[Ivan Posva, 2014-05-02 04:58:56]

-Ivan

https://codereview.chromium.org/265713006/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/265713006/diff/1/runtime/vm/debugger.cc#newco...
runtime/vm/debugger.cc:1550: if (last_token_pos < func.end_token_pos()) {
This looks a bit strange to me. First we start by determining the extent of the
token positions on a line (in SetBreakpointAtLine) and then we allow setting of
a breakpoint anywhere within the function here. Let's discuss in person.

[Ivan Posva, 2014-05-05 17:20:42]

LGTM -ip

[hausner, 2014-05-05 17:28:52]

Committed patchset #1 manually as r35749 (presubmit successful).