Issue 263313003: Fix an analyzer error in pkg/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263313003: Fix an analyzer error in pkg/http. (Closed)

Created:
6 years, 7 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix an analyzer error in pkg/http. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35761

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -3 lines)			Patch
M	pkg/http/CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/http/lib/browser_client.dart	View	2 chunks	+1 line, -2 lines	2 comments	Download
M	pkg/http/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/263313003/diff/1/pkg/http/lib/browser_client.dart File pkg/http/lib/browser_client.dart (right): https://codereview.chromium.org/263313003/diff/1/pkg/http/lib/browser_client.dart#newcode68 pkg/http/lib/browser_client.dart:68: completer.completeError( Oof. Oops.

6 years, 7 months ago (2014-05-05 19:59:33 UTC) #2

nweiz

https://codereview.chromium.org/263313003/diff/1/pkg/http/lib/browser_client.dart File pkg/http/lib/browser_client.dart (right): https://codereview.chromium.org/263313003/diff/1/pkg/http/lib/browser_client.dart#newcode68 pkg/http/lib/browser_client.dart:68: completer.completeError( On 2014/05/05 19:59:34, Bob Nystrom wrote: > Oof. ...

6 years, 7 months ago (2014-05-05 20:00:14 UTC) #3

nweiz

6 years, 7 months ago (2014-05-05 20:00:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r35761 (presubmit successful).

Expand Messages | Collapse Messages