pkg/http/lib/browser_client.dart - Issue 263313003: Fix an analyzer error in pkg/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/http/lib/browser_client.dart

Issue 263313003: Fix an analyzer error in pkg/http. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/http/lib/browser_client.dart

diff --git a/pkg/http/lib/browser_client.dart b/pkg/http/lib/browser_client.dart

index 957784ba3dcf15bcea659efbe5a1a179e87a1e26..911c8427f520573909bf86a095ae808b1331fb4f 100644

--- a/pkg/http/lib/browser_client.dart

+++ b/pkg/http/lib/browser_client.dart

@@ -6,7 +6,6 @@ library http.browser_client;

import 'dart:async';

import 'dart:html';

-import 'dart:typed_data';

import 'package:stack_trace/stack_trace.dart';

@@ -66,7 +65,7 @@ class BrowserClient extends BaseClient {

});

reader.onError.first.then((error) {

- completer.complete(

+ completer.completeError(

Bob Nystrom 2014/05/05 19:59:34 Oof. Oops.

nweiz 2014/05/05 20:00:14 Luckily I don't think this code path can actually

new ClientException(error.toString(), request.url),

new Chain.current());

});

« no previous file with comments | « pkg/http/CHANGELOG.md ('k') | pkg/http/pubspec.yaml » ('j') | no next file with comments »