Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 263013006: Add function parameter info in docgen. (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
Reviewers:
Alan Knight, kevmoo
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add function parameter info in docgen. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=35866

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
A pkg/docgen/lib/src/models/closure.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M pkg/docgen/lib/src/models/method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/src/models/parameter.dart View 1 2 3 chunks +27 lines, -11 lines 0 comments Download
A pkg/docgen/test/method_param_test.dart View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M pkg/docgen/test/multi_library_code/lib/test_lib2.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
Docgen change corresponding to: https://codereview.chromium.org/273473002/ Not thrilled with the name "closure" ... feels like I'm ...
6 years, 7 months ago (2014-05-06 22:44:20 UTC) #1
kevmoo
DBC https://codereview.chromium.org/263013006/diff/20001/pkg/docgen/lib/src/models/parameter.dart File pkg/docgen/lib/src/models/parameter.dart (right): https://codereview.chromium.org/263013006/diff/20001/pkg/docgen/lib/src/models/parameter.dart#newcode21 pkg/docgen/lib/src/models/parameter.dart:21: String name; Does this need to be mutable?
6 years, 7 months ago (2014-05-06 23:05:08 UTC) #2
Emily Fortuna
https://codereview.chromium.org/263013006/diff/20001/pkg/docgen/lib/src/models/parameter.dart File pkg/docgen/lib/src/models/parameter.dart (right): https://codereview.chromium.org/263013006/diff/20001/pkg/docgen/lib/src/models/parameter.dart#newcode21 pkg/docgen/lib/src/models/parameter.dart:21: String name; On 2014/05/06 23:05:08, kevmoo wrote: > Does ...
6 years, 7 months ago (2014-05-06 23:19:43 UTC) #3
Alan Knight
lgtm
6 years, 7 months ago (2014-05-07 16:58:37 UTC) #4
Emily Fortuna
6 years, 7 months ago (2014-05-07 20:35:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r35866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698