Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 26293003: Check for null, when packages dir has no parent. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Check for null, when packages dir has no parent. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/PackageUriResolver.java View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 2 months ago (2013-10-08 03:22:28 UTC) #1
scheglov
Committed patchset #1 manually as r28352 (presubmit successful).
7 years, 2 months ago (2013-10-08 03:23:19 UTC) #2
Brian Wilkerson
7 years, 2 months ago (2013-10-08 13:15:10 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698