pkg/analyzer_experimental/lib/src/generated/source_io.dart - Issue 26293003: Check for null, when packages dir has no parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_experimental/lib/src/generated/source_io.dart

Issue 26293003: Check for null, when packages dir has no parent. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer_experimental/lib/src/generated/source_io.dart

diff --git a/pkg/analyzer_experimental/lib/src/generated/source_io.dart b/pkg/analyzer_experimental/lib/src/generated/source_io.dart

index 692b0e2e89ae0f578f4e42c3daf101c5335515df..72ff203a5a86c7f7a600b9f0eeaed390e7a55e52 100644

--- a/pkg/analyzer_experimental/lib/src/generated/source_io.dart

+++ b/pkg/analyzer_experimental/lib/src/generated/source_io.dart

@@ -261,6 +261,9 @@ class PackageUriResolver extends UriResolver {

bool isSelfReference(JavaFile packagesDir, JavaFile file) {

JavaFile rootDir = packagesDir.getParentFile();

+ if (rootDir == null) {

+ return false;

+ }

String rootPath = rootDir.getAbsolutePath();

String filePath = file.getAbsolutePath();

return filePath.startsWith("${rootPath}/lib");