Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 26284002: Rename "install" -> "get" and "update" -> "upgrade". (Closed)

Created:
7 years, 2 months ago by Bob Nystrom
Modified:
7 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename "install" -> "get" and "update" -> "upgrade". BUG=https://code.google.com/p/dart/issues/detail?id=7351 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=28330

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -2965 lines) Patch
M sdk/lib/_internal/pub/lib/src/command.dart View 3 chunks +5 lines, -5 lines 0 comments Download
A + sdk/lib/_internal/pub/lib/src/command/get.dart View 1 chunk +9 lines, -9 lines 0 comments Download
D sdk/lib/_internal/pub/lib/src/command/install.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 1 chunk +5 lines, -6 lines 2 comments Download
D sdk/lib/_internal/pub/lib/src/command/update.dart View 1 chunk +0 lines, -43 lines 0 comments Download
A + sdk/lib/_internal/pub/lib/src/command/upgrade.dart View 3 chunks +11 lines, -11 lines 2 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 4 chunks +37 lines, -37 lines 6 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source.dart View 10 chunks +35 lines, -33 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/git.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 7 chunks +12 lines, -12 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/path.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source_registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 3 chunks +14 lines, -14 lines 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_browser_js_next_to_entrypoints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/broken_symlink_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_and_upgrade_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_branch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_revision_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_transitive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_twice_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/check_out_with_trailing_slash_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/dependency_name_match_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/different_repo_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/lock_version_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/require_pubspec_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/require_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/stay_locked_if_compatible_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/git/unlock_if_incompatible_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/cached_pubspec_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/do_not_upgrade_on_removed_constraints_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/get_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/get_transitive_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/repair_cache_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/resolve_constraints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/stay_locked_if_compatible_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/stay_locked_if_new_is_satisfied_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/stay_locked_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/unlock_if_incompatible_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/hosted/unlock_if_new_is_unsatisfied_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/absolute_path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/absolute_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/no_pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/nonexistent_dir_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/path_is_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/relative_path_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/relative_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/shared_dependency_symlink_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/get/path/shared_dependency_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/relative_symlink_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/get/switch_source_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/offline_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/hosted/version_negotiation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/test/install/broken_symlink_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_and_update_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_branch_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_revision_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_transitive_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_twice_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/check_out_with_trailing_slash_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/different_repo_name_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/lock_version_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/git/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/cached_pubspec_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/do_not_update_on_removed_constraints_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/install_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/install_transitive_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/repair_cache_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/resolve_constraints_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/stay_locked_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/absolute_path_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/absolute_symlink_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/relative_symlink_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/path/shared_dependency_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/relative_symlink_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D sdk/lib/_internal/pub/test/install/switch_source_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M sdk/lib/_internal/pub/test/list_package_dirs/ignores_updated_pubspec_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/list_package_dirs/includes_dev_dependencies_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/list_package_dirs/lists_dependency_directories_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/list_package_dirs/no_lockfile_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/pub_get_and_upgrade_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/test/pub_install_and_update_test.dart View 1 chunk +0 lines, -141 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_test.dart View 3 chunks +11 lines, -11 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/does_not_get_first_if_a_dependency_is_removed_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/does_not_get_first_if_git_url_did_not_change_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/does_not_get_first_if_locked_version_matches_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/does_not_install_first_if_a_dependency_is_removed_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/does_not_install_first_if_git_url_did_not_change_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/does_not_install_first_if_locked_version_matches_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_dependency_added_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_dependency_version_changed_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_dev_dependency_changed_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_git_ref_changed_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_git_url_changed_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_no_lockfile_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_path_dependency_changed_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + sdk/lib/_internal/pub/test/serve/gets_first_if_source_changed_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_dependency_added_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_dependency_version_changed_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_dev_dependency_changed_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_git_ref_changed_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_git_url_changed_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_no_lockfile_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_path_dependency_changed_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sdk/lib/_internal/pub/test/serve/installs_first_if_source_changed_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/invalid_urls_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/missing_dependency_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_dependency_asset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_dependency_lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/utils.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 3 chunks +15 lines, -15 lines 0 comments Download
M sdk/lib/_internal/pub/test/transformer/dart2js/allows_import_in_dart_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/transformer/dart2js/ignores_entrypoint_in_dependency_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/unknown_source_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/git/update_locked_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/git/update_one_locked_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/git/update_to_incompatible_pubspec_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/hosted/unlock_dependers_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/hosted/unlock_if_necessary_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/git/do_not_upgrade_if_unneeded_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/git/upgrade_locked_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/git/upgrade_one_locked_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/hosted/unlock_dependers_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/hosted/unlock_if_necessary_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/upgrade/hosted/upgrade_removed_constraints_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bob Nystrom
I went through everything and removed all uses of "install" and "update" that referred to ...
7 years, 2 months ago (2013-10-07 16:45:50 UTC) #1
nweiz
A couple of suggestions, otherwise lgtm. https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart File sdk/lib/_internal/pub/lib/src/command/serve.dart (right): https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart#newcode129 sdk/lib/_internal/pub/lib/src/command/serve.dart:129: log.message("Dependencies have changed, ...
7 years, 2 months ago (2013-10-07 21:25:14 UTC) #2
Bob Nystrom
Committed patchset #1 manually as r28330 (presubmit successful).
7 years, 2 months ago (2013-10-07 22:24:39 UTC) #3
Bob Nystrom
https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart File sdk/lib/_internal/pub/lib/src/command/serve.dart (right): https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart#newcode129 sdk/lib/_internal/pub/lib/src/command/serve.dart:129: log.message("Dependencies have changed, getting..."); On 2013/10/07 21:25:15, nweiz wrote: ...
7 years, 2 months ago (2013-10-07 22:32:24 UTC) #4
nweiz
https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/entrypoint.dart File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right): https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src/entrypoint.dart#newcode108 sdk/lib/_internal/pub/lib/src/entrypoint.dart:108: /// Gets all dependencies of the [root] package and ...
7 years, 2 months ago (2013-10-07 23:23:07 UTC) #5
Bob Nystrom
7 years, 2 months ago (2013-10-08 21:15:03 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right):

https://codereview.chromium.org/26284002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/entrypoint.dart:108: /// Gets all dependencies of
the [root] package and places them in its
On 2013/10/07 23:23:08, nweiz wrote:
> On 2013/10/07 22:32:25, Bob Nystrom wrote:
> > On 2013/10/07 21:25:15, nweiz wrote:
> > > "Gets" -> "Downloads", since placing them in the "packages" directory is
> > defined
> > > as the difference between the two. Same for [upgradeDependencies] and
> > > [upgradeAllDependencies].
> > 
> > I've tried to have "download" consistently mean "put in system cache" and
> "get"
> > mean "make available for use by a package" (which may sometimes require
> > downloading first).
> > 
> > In the case where all of your dependencies are path, none of these functions
> > will hit the system cache, so I think "get" is right here.
> 
> I feel like if you're going to use "get" here you shouldn't also explicitly
call
> out that it "places them in its 'packages' directory", since that's part of
what
> "get" means. Saying it explicitly makes the distinction less clear.

Done. See: https://codereview.chromium.org/26284002

Powered by Google App Engine
This is Rietveld 408576698