Issue 262803003: Unify error messages for iterables and lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262803003: Unify error messages for iterables and lists. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Unify error messages for iterables and lists. Add factory methods that generate the errors thrown for unmodifiable lists, non-growable lists and iterations with the wrong number of elements. R=iposva@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35733

Patch Set 1 #

Total comments: 1

Patch Set 2 : Capitalize messages. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -123 lines)			Patch
M	runtime/lib/array.dart	View		7 chunks	+41 lines, -74 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/collection/iterable.dart	View		14 chunks	+18 lines, -18 lines	0 comments	Download
M	sdk/lib/internal/iterable.dart	View	1	19 chunks	+39 lines, -27 lines	0 comments	Download
M	sdk/lib/internal/list.dart	View		1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/262803003/diff/1/sdk/lib/internal/iterable.dart File sdk/lib/internal/iterable.dart (right): https://codereview.chromium.org/262803003/diff/1/sdk/lib/internal/iterable.dart#newcode1174 sdk/lib/internal/iterable.dart:1174: static StateError noElement() => new StateError("no element"); First ...

6 years, 7 months ago (2014-05-01 13:13:37 UTC) #2

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-05-05 09:27:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35733 (presubmit successful).

Expand Messages | Collapse Messages