Unify error messages for iterables and lists.

runtime/lib/array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 // TODO(srdjan): Use shared array implementation.
 class _List<E> implements List<E> {
   static final int _classId = (new _List(0))._cid;
 
   factory _List(length) native "List_allocate";
 
   E operator [](int index) native "List_getIndexed";
 
   void operator []=(int index, E value) native "List_setIndexed";
 
   String toString() {
     return IterableMixinWorkaround.toStringIterable(this,'[' , ']');
   }
 
   int get length native "List_getLength";
 
   void _copyFromObjectArray(_List src,
                             int srcStart,
                             int dstStart,
                             int count)
       native "List_copyFromObjectArray";
 
   void insert(int index, E element) {
-    throw new UnsupportedError(
-        "Cannot insert into a fixed-length list");
+    throw NonGrowableListError.add();
   }
 
   void insertAll(int index, Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot insert into a fixed-length list");
+    throw NonGrowableListError.add();
   }
 
   void setAll(int index, Iterable<E> iterable) {
     IterableMixinWorkaround.setAllList(this, index, iterable);
   }
 
   E removeAt(int index) {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   bool remove(Object element) {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   void removeWhere(bool test(E element)) {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   void retainWhere(bool test(E element)) {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   Iterable<E> getRange(int start, [int end]) {
     return IterableMixinWorkaround.getRangeList(this, start, end);
   }
 
   // List interface.
   void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
     if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
@@ skipping 17 matching lines @@
         }
         for (int i = start; i < end; i++) {
           if (!it.moveNext()) return;
           this[i] = it.current;
         }
       }
     }
   }
 
   void removeRange(int start, int end) {
-    throw new UnsupportedError(
-        "Cannot remove range from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   void replaceRange(int start, int end, Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot remove range from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   void fillRange(int start, int end, [E fillValue]) {
     IterableMixinWorkaround.fillRangeList(this, start, end, fillValue);
   }
 
   List<E> sublist(int start, [int end]) {
     Lists.indicesCheck(this, start, end);
     if (end == null) end = this.length;
     int length = end - start;
@@ skipping 101 matching lines @@
   int lastIndexOf(Object element, [int start = null]) {
     if (start == null) start = length - 1;
     return Lists.lastIndexOf(this, element, start);
   }
 
   Iterator<E> get iterator {
     return new _FixedSizeArrayIterator<E>(this);
   }
 
   void add(E element) {
-    throw new UnsupportedError(
-        "Cannot add to a fixed-length list");
+    throw NonGrowableListError.add();
   }
 
   void addAll(Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot add to a fixed-length list");
+    throw NonGrowableListError.add();
   }
 
   void clear() {
-    throw new UnsupportedError(
-        "Cannot clear a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   void set length(int length) {
-    throw new UnsupportedError(
-        "Cannot resize a fixed-length list");
+    throw NonGrowableListError.length();
   }
 
   E removeLast() {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw NonGrowableListError.remove();
   }
 
   E get first {
     if (length > 0) return this[0];
-    throw new StateError("No elements");
+    throw IterableElementError.noElement();
   }
 
   E get last {
     if (length > 0) return this[length - 1];
-    throw new StateError("No elements");
+    throw IterableElementError.noElement();
   }
 
   E get single {
     if (length == 1) return this[0];
-    if (length == 0) throw new StateError("No elements");
-    throw new StateError("More than one element");
+    if (length == 0) throw IterableElementError.noElement();
+    throw IterableElementError.tooMany();
   }
 
   List<E> toList({ bool growable: true}) {
     return new List<E>.from(this, growable: growable);
   }
 
   Set<E> toSet() {
     return new Set<E>.from(this);
   }
 
@@ skipping 17 matching lines @@
     throw new UnsupportedError(
         "ImmutableArray can only be allocated by the VM");
   }
 
   factory _ImmutableList._from(List from, int offset, int length)
       native "ImmutableList_from";
 
   E operator [](int index) native "List_getIndexed";
 
   void operator []=(int index, E value) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   int get length native "List_getLength";
 
   void insert(int index, E element) {
-    throw new UnsupportedError(
-        "Cannot add to an immutable array");
+    throw UnmodifiableListError.add();
   }
 
   void insertAll(int index, Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot add to an immutable array");
+    throw UnmodifiableListError.add();
   }
 
   void setAll(int index, Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   E removeAt(int index) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   bool remove(Object element) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   void removeWhere(bool test(E element)) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   void retainWhere(bool test(E element)) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   void copyFrom(List src, int srcStart, int dstStart, int count) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   void removeRange(int start, int end) {
-    throw new UnsupportedError(
-        "Cannot remove range of an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   void fillRange(int start, int end, [E fillValue]) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   void replaceRange(int start, int end, Iterable<E> iterable) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   List<E> sublist(int start, [int end]) {
     Lists.indicesCheck(this, start, end);
     if (end == null) end = this.length;
     int length = end - start;
     if (start == end) return [];
     List list = new List<E>();
     list.length = length;
     Lists.copy(this, start, list, 0, length);
@@ skipping 80 matching lines @@
 
   bool get isEmpty {
     return this.length == 0;
   }
 
   bool get isNotEmpty => !isEmpty;
 
   Iterable<E> get reversed => IterableMixinWorkaround.reversedList(this);
 
   void sort([int compare(E a, E b)]) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   void shuffle([Random random]) {
-    throw new UnsupportedError(
-        "Cannot modify an immutable array");
+    throw UnmodifiableListError.change();
   }
 
   String toString() {
     return IterableMixinWorkaround.toStringIterable(this, '[', ']');
   }
 
   int indexOf(Object element, [int start = 0]) {
     return Lists.indexOf(this, element, start, this.length);
   }
 
   int lastIndexOf(Object element, [int start = null]) {
     if (start == null) start = length - 1;
     return Lists.lastIndexOf(this, element, start);
   }
 
   Iterator<E> get iterator {
     return new _FixedSizeArrayIterator<E>(this);
   }
 
   void add(E element) {
-    throw new UnsupportedError(
-        "Cannot add to an immutable array");
+    throw UnmodifiableListError.add();
   }
 
   void addAll(Iterable<E> elements) {
-    throw new UnsupportedError(
-        "Cannot add to an immutable array");
+    throw UnmodifiableListError.add();
   }
 
   void clear() {
-    throw new UnsupportedError(
-        "Cannot clear an immutable array");
+    throw UnmodifiableListError.remove();
   }
 
   void set length(int length) {
-    throw new UnsupportedError(
-        "Cannot change the length of an immutable array");
+    throw UnmodifiableListError.length();
   }
 
   E removeLast() {
-    throw new UnsupportedError(
-        "Cannot remove from a fixed-length list");
+    throw UnmodifiableListError.remove();
   }
 
   E get first {
     if (length > 0) return this[0];
-    throw new StateError("No elements");
+    throw IterableElementError.noElement();
   }
 
   E get last {
     if (length > 0) return this[length - 1];
-    throw new StateError("No elements");
+    throw IterableElementError.noElement();
   }
 
   E get single {
     if (length == 1) return this[0];
-    if (length == 0) throw new StateError("No elements");
-    throw new StateError("More than one element");
+    if (length == 0) throw IterableElementError.noElement();
+    throw IterableElementError.tooMany();
   }
 
   List<E> toList({ bool growable: true }) {
     return new List<E>.from(this, growable: growable);
   }
 
   Set<E> toSet() {
     return new Set<E>.from(this);
   }
 
@@ skipping 24 matching lines @@
     }
     _position = _length;
     _current = null;
     return false;
   }
 
   E get current {
     return _current;
   }
 }