Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262303002: Observatory grab-bag for 1.4 release. (Closed)

Created:
6 years, 7 months ago by turnidge
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Observatory grab-bag for 1.4 release. - Make nav bar stick to the top - Classes, functions, libraries are not immutable - Expand some short lists by default - Use uri to make a name for unnamed libraries - Add Library class - Fix z-index for navbar relative to heap map status pane - Make NetworkError look nicer - Dispatch known instance types to <instance-view> BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35785

Patch Set 1 #

Patch Set 2 : fix navbar #

Patch Set 3 : last minute edits #

Patch Set 4 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -247 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 31 chunks +96 lines, -60 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 31 chunks +96 lines, -60 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/breakpoint_list.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_map.html View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_profile.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_profile.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 3 6 chunks +37 lines, -27 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 3 6 chunks +18 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_error_view.html View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_exception_view.html View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_trace.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/breakpoint_list.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/curly_block.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/error_view.html View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_map.html View 1 1 chunk +10 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_profile.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_view.html View 1 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.html View 1 2 6 chunks +37 lines, -27 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 6 chunks +18 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_error_view.html View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 2 chunks +24 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_trace.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 5 chunks +52 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 7 months ago (2014-05-05 21:04:33 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-05 21:10:21 UTC) #2
turnidge
6 years, 7 months ago (2014-05-06 04:05:45 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r35785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698