Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/service_view.dart

Issue 262303002: Observatory grab-bag for 1.4 release. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/service_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/service_view.dart b/runtime/bin/vmservice/client/lib/src/elements/service_view.dart
index 822645f657f7e554e8dfa9b1707f757e5b542d36..5b08d8a9d3a9f01d792aa96ee2448cfffc122218 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/service_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/service_view.dart
@@ -52,6 +52,28 @@ class ServiceObjectViewElement extends ObservatoryElement {
HeapMapElement element = new Element.tag('heap-map');
element.fragmentation = object;
return element;
+ case 'LibraryPrefix':
+ case 'TypeRef':
+ case 'TypeParameter':
+ case 'BoundedType':
+ case 'Int32x4':
+ case 'Float32x4':
+ case 'Float64x4':
+ case 'TypedData':
+ case 'ExternalTypedData':
+ case 'Capability':
+ case 'ReceivePort':
+ case 'SendPort':
+ case 'Stacktrace':
+ case 'JSRegExp':
+ case 'WeakProperty':
+ case 'MirrorReference':
+ case 'UserTag':
+ // TODO(turnidge): The types above this comment are instance
+ // types and should be handled by the InstanceViewElement. We
+ // need to go through these and make sure that they print in a
+ // reasonable way.
+ case 'Type':
case 'Array':
case 'Bool':
case 'Closure':
@@ -59,8 +81,9 @@ class ServiceObjectViewElement extends ObservatoryElement {
case 'GrowableObjectArray':
case 'Instance':
case 'Smi':
+ case 'Mint':
+ case 'Bigint':
case 'String':
- case 'Type':
InstanceViewElement element = new Element.tag('instance-view');
element.instance = object;
return element;

Powered by Google App Engine
This is Rietveld 408576698